Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ambiguity in usage of maven properties docs #507

Conversation

abelsromero
Copy link
Member

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Improve docs about usage of Maven properties.
Now it should be more clear that now only properties set in the pom are passed as attributes.

Are there any alternative ways to implement this?
Explanation could be extended to explicitely state that Maven Model are NOT set. But for now I'd like to keep it simple.
Also, the text is duplu

Are there any implications of this pull request? Anything a user must know?
Need to refresh general docs site.

Is it related to an existing issue?

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero abelsromero force-pushed the docs/improve-maven-properties-usage branch from e755ea2 to ad9c325 Compare January 2, 2021 15:43
@coveralls
Copy link

coveralls commented Jan 2, 2021

Coverage Status

Coverage remained the same at 84.971% when pulling ad9c325 on abelsromero:docs/improve-maven-properties-usage into 865c4d8 on asciidoctor:master.

@abelsromero abelsromero merged commit 20f5923 into asciidoctor:master Jan 5, 2021
@abelsromero abelsromero deleted the docs/improve-maven-properties-usage branch April 10, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants