fixes #206 - adds the option to set attributes through command line an… #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
changed the title
abelsromero
force-pushed
the
issue_206_attributes_command
branch
from
cd6c261 to
f030632
Compare
|
I'd just like to say, this is pretty darn cool. One small request to the docs, though not directly related to this code change. Could you use "highlight.js" as the attribute value instead of "highlightjs"? We're trying to standardize that a bit and I think using the actually library name is the best way to go. |
…mand line and updates README
abelsromero
force-pushed
the
issue_206_attributes_command
branch
from
f030632 to
f309e64
Compare
|
Done! I also updated the tests and other references in the README. |
|
Thanks! |
abelsromero
added a commit
that referenced
this pull request
Feb 21, 2016
fixes #206 - adds the option to set attributes through command line an…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reconfigures the attributes configuration in AsciidoctorMojo to allow setting them using command line options in the same as in asciidoctor.
This PR does not replace or change in any way how attributes are set using the standard XML.