Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip mojo problem with assembly plugin #145

Open
jeffmaury opened this issue Jan 14, 2015 · 11 comments
Open

Zip mojo problem with assembly plugin #145

jeffmaury opened this issue Jan 14, 2015 · 11 comments
Milestone

Comments

@jeffmaury
Copy link

Hello,

I am facing the following issue: I'm building a ZIP file of HTML produced by the Zip mojo and it's working file. But this artifact is then used and unzipped by the assembly plugin. Then the content of the assembly is processed by another Maven plugin (IZpack). The problem I have is that the files extracted from the ZIP file have no read/write/execute flags set. I have looked at the ZIP file and the Host OS is set to FAT and it seems to be no attributes.
I have this problem only on Linux not on Windows
image

@mojavelinux
Copy link
Member

I understand the problem you are having but I don't see how it has anything
to do with the Asciidoctor plugin. Are you suggesting a correlation, or
have you filed the issue with the wrong project?

@jeffmaury
Copy link
Author

No, it is correlated as the ZIP file is produced by the asciidoctor zip mojo.

@LightGuard
Copy link
Member

This is exactly why I didn't want to have one plugin do the work of many.

On Wed, Jan 14, 2015 at 12:48 PM, Jeff MAURY [email protected]
wrote:

No, it is correlated as the ZIP file is produced by the asciidoctor zip
mojo.


Reply to this email directly or view it on GitHub
#145 (comment)
.

Jason Porter
http://en.gravatar.com/lightguardjp

@mojavelinux
Copy link
Member

Hahaha. I didn't even realize the Asciidoctor plugin produced a zip. Shouldn't that be handled by the assembly plugin (as I think Jason is suggesting)?

@LightGuard
Copy link
Member

That was my take originally.

On Wed, Jan 14, 2015 at 1:28 PM, Dan Allen [email protected] wrote:

Hahaha. I didn't even realize the Asciidoctor plugin produced a zip.
Shouldn't that be handled by the assembly plugin (as I think Jason is
suggesting)?


Reply to this email directly or view it on GitHub
#145 (comment)
.

Jason Porter
http://en.gravatar.com/lightguardjp

@jeffmaury
Copy link
Author

That was how I did a workaround for the problem (asciidoctor generating the HTML files and the assembly plugin buiding the Zip). But I wanted to signal the problem and get feedback to/from the community

@LightGuard
Copy link
Member

I haven't heard of anyone else (besides the person who put it in) who was
using it. I'm not even sure if it's documented (probably not as you hit
this issue). I'm tempted to say let's deprecate it.

On Wed, Jan 14, 2015 at 2:40 PM, Jeff MAURY [email protected]
wrote:

That was how I did a workaround for the problem (asciidoctor generating
the HTML files and the assembly plugin buiding the Zip). But I wanted to
signal the problem and get feedback to/from the community


Reply to this email directly or view it on GitHub
#145 (comment)
.

Jason Porter
http://en.gravatar.com/lightguardjp

@jeffmaury
Copy link
Author

+1 for deprecation

@abelsromero
Copy link
Member

I think the same, we should stick to what we do best. That's making awsome documents 👍
Currently we could set the Mojo as "unsuported" and remove it in some future versions.

@LightGuard
Copy link
Member

There are some other gems in there that I think we should do the same. Like
the server that's in there :)

On Wed, Jan 14, 2015 at 2:54 PM, Abel Salgado Romero <
[email protected]> wrote:

I think the same, we should stick to what we do best. That's making awsome
documents [image: 👍]
Currently we could set the Mojo as "unsuported" and remove it in some
future versions.


Reply to this email directly or view it on GitHub
#145 (comment)
.

Jason Porter
http://en.gravatar.com/lightguardjp

@abelsromero abelsromero added this to the 3.0.0 milestone May 31, 2020
@abelsromero
Copy link
Member

Sorry, Zip mojo is marked for removal at some point and no longer supported.

@abelsromero abelsromero added 3.0.0 and removed 3.0.0 labels Feb 11, 2024
@abelsromero abelsromero modified the milestones: 3.0.0, Maven v4 Feb 11, 2024
@abelsromero abelsromero reopened this Feb 11, 2024
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this issue Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants