Skip to content

Commit

Permalink
Fix and test Javadoc generation (#708)
Browse files Browse the repository at this point in the history
  • Loading branch information
abelsromero authored Dec 29, 2023
1 parent 88aa5ae commit b8a34e1
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 2 deletions.
20 changes: 20 additions & 0 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,23 @@ jobs:
run: mvn -version
- name: Build & Test
run: mvn -B -Prun-its clean verify
javadocs:
name: Javadocs
strategy:
fail-fast: false
matrix:
os:
- ubuntu-latest
java:
- 11
maven:
- 3.9.6
runs-on: ${{ matrix.os }}
steps:
- uses: s4u/[email protected]
with:
java-distribution: 'temurin'
java-version: ${{ matrix.java }}
maven-version: ${{ matrix.maven }}
- name: Build & Test
run: mvn -B clean javadoc:jar
1 change: 1 addition & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Build / Infrastructure::
* Add Java 21 to CI (#664)
* Add Dependabot to automate dependency management (#669)
* Improvements to dependency management (#690)
* Test Javadoc generation in CI (#690)

Documentation::

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
/**
* {@link ResourcesProcessor} implementation that copies all valid resources from
* a source directory to an output one.
* <p/>
* <p>
* Following resources are not valid:
* - AsciiDoc documents: based on file extension.
* - Asciidoctor Docinfo files.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ protected Sink getSink() {

/**
* Tests for the presence of an attribute in current and parent nodes.
* Returns first match.
*
* @param name attribute name
* @param node node to check
* @return true if attribute is found
*/
protected boolean hasAttribute(String name, ContentNode node) {
ContentNode current = node;
Expand Down

0 comments on commit b8a34e1

Please sign in to comment.