This repository has been archived by the owner on Nov 21, 2017. It is now read-only.
Update to asciidoctor.js 1.5.2 and opal 0.6.3 #23
+877
−558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,6 @@ | |||
| /* Asciidoctor default stylesheet | MIT License | http://asciidoctor.org */ | |||
| @import "https://fonts.googleapis.com/css?family=Open+Sans:300,300italic,400,400italic,600,600italic|Noto+Serif:400,400italic,700,700italic|Droid+Sans+Mono:400"; | |||
| /* Remove the comments around the @import statement below when using this as a custom stylesheet */ | |||
| /*@import "https://fonts.googleapis.com/css?family=Open+Sans:300,300italic,400,400italic,600,600italic%7CNoto+Serif:400,400italic,700,700italic%7CDroid+Sans+Mono:400";*/ | |||
There was a problem hiding this comment.
This @import line should be uncommented when used in the Firefox add-on. The reason is the Firefox addon renders the document to embeddable HTML, which does not include the fonts. This is kind of a pain atm, but suffice to say, it's a necessary manual change.
|
Uncomment the |
|
Thanks again @jmini 👍 |
|
If I understand the GitHub workflow correctly, I have forced pushed an amended commit on my master branch. This new commit contains the fix asked by @mojavelinux |
|
You did it exactly right! Good job.
|
ggrossetie
added a commit
that referenced
this pull request
Feb 6, 2015
Update to asciidoctor.js 1.5.2 and opal 0.6.3
|
Perfect 🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #22