forked from skypilot-org/skypilot
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch affinity to work with dws #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaiacai
added a commit
that referenced
this pull request
Oct 25, 2024
* patch affinity to work with dws * lint
asaiacai
added a commit
that referenced
this pull request
Oct 26, 2024
* patch affinity to work with dws * lint lint
asaiacai
added a commit
that referenced
this pull request
Nov 5, 2024
* patch affinity to work with dws * lint
asaiacai
added a commit
that referenced
this pull request
Nov 5, 2024
* patch affinity to work with dws * lint lint
asaiacai
added a commit
that referenced
this pull request
Nov 5, 2024
* [docs]: OCI key_file path clarrification (skypilot-org#4262) * [docs]: OCI key_file path clarrification * Update installation.rst * [k8s] Parallelize setup for faster multi-node provisioning (skypilot-org#4240) * parallelize setup * lint * Add retries * lint * retry for get_remote_home_dir * optimize privilege check * parallelize termination * increase num threads * comments * lint * K8s pod dns (#6) * enumerate worker pods, bind pod_name to headless service * patch worker numbering * allow any traffic between sky pods * add test for ssh vs hostname * fix ip-worker mapping for k8s ssh * lint * Update README.md * Update pypi-nightly-build.yml point build to our pypi project * patch affinity to work with dws (#7) * patch affinity to work with dws * lint * patch affinity to work with dws (#7) * patch affinity to work with dws * lint lint * lint --------- Co-authored-by: Hysun He <[email protected]> Co-authored-by: Romil Bhardwaj <[email protected]>
asaiacai
added a commit
that referenced
this pull request
Dec 12, 2024
* K8s pod dns (#6) * enumerate worker pods, bind pod_name to headless service * patch worker numbering * allow any traffic between sky pods * add test for ssh vs hostname * fix ip-worker mapping for k8s ssh * lint * Update README.md * Update pypi-nightly-build.yml point build to our pypi project * patch affinity to work with dws (#7) * patch affinity to work with dws * lint patch affinity to work with dws (#7) * patch affinity to work with dws * lint lint lint Update pypi-nightly-build.yml point build to our pypi project patch affinity to work with dws (#7) * patch affinity to work with dws * lint lint * Nebius Labeling * nebius2 * Save local changes before merging upstream * value error + support accelerators * formatting --------- Co-authored-by: Andrew Aikawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so the podset has only one kind of pod which can work with dws
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh