Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where navigationItem would not be displayed under iOS 7 #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timbodeit
Copy link

For reasons, that I currenlty do not understand, the self.enableShadow and
self.enableSwipeGesture calls in SlideNavigationController#setup cause problems
under iOS 7 in my setup.
I am instanciating a SlideNavigationController through a storyboard. While iOS
8 and 9 work fine, under iOS 7 I was seeing an empty navigation bar. It did
have a navigationItem, though that didn't match the topViewController and
didn't have any title or buttonItems.

I assume this issue arises from enableShadow and enableSwipeGesture both
accessing the view property, while being called before viewDidLoad.

Deferring both of these calls and making them during them during viewDidLoad
instead of during init, resolves the issue that I have been seeing under iOS 7.

For reasons, that I currenlty do not understand, the self.enableShadow and
self.enableSwipeGesture calls in SlideNavigationController#setup cause problems
under iOS 7 in my setup.
I am instanciating a SlideNavigationController through a storyboard. While iOS
8 and 9 work fine, under iOS 7 I was seeing an empty navigation bar. It did
have a navigationItem, though that didn't match the topViewController and
didn't have any title or buttonItems.

I assume this issue arises from enableShadow and enableSwipeGesture both
accessing the view property, while being called before viewDidLoad.

Deferring both of these calls and making them during them during viewDidLoad
instead of during init, resolves the issue that I have been seeing under iOS 7.
@aryaxt
Copy link
Owner

aryaxt commented Feb 19, 2016

Thanks for the PR: Couple of questions

1- Are you able to reproduce this in the demo app?
2- Are you setting your barbuttons in storyboard or in code? if in code are you doing after viewDidLoad?
3- Do you have a sample with this issue?

self.enableShadow and self.enableSwipeGesture call setup because as you try to access them the singleton object gets instantiated.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants