Skip to content
This repository has been archived by the owner on Mar 18, 2022. It is now read-only.

HBO España + Nordic #13

Merged
merged 17 commits into from
May 8, 2019
Merged

HBO España + Nordic #13

merged 17 commits into from
May 8, 2019

Conversation

Sakerdot
Copy link
Contributor

@Sakerdot Sakerdot commented Apr 7, 2019

#6

Starting point for the development of HBO España.

ATM only https://es.hboespana.com/ login endpoint is supported, there isn't any info on episodes/seasons/tv shows but at least they can be played.

Code right now is messy and probably bug ridden, but if someone wanted to use HBO España on Kodi (specially after 15th of April...) here you go.

@Sakerdot
Copy link
Contributor Author

Sakerdot commented Apr 7, 2019

It probably shouldn't be merged right now, I just wanted to have something to play HBO before the last GoT season is released.

@arvvoid arvvoid added the enhancement New feature or request label Apr 8, 2019
@arvvoid arvvoid modified the milestones: v.3.0.EU, v.2.0.EU Apr 8, 2019
@arvvoid
Copy link
Owner

arvvoid commented Apr 8, 2019

Hello, good job :) I like the direction where this is going. Can't test the Spain handler because I don't have a Spain account but tested the add-on with your changes and it does not break any existing functionality, so it can be safely merged at any time.

For now, I will wait with merging until this is more mature and tested.

I made a zip for easy installation of your version so far, for easy testing:
plugin.video.hbogoeu-spain.zip

@arvvoid
Copy link
Owner

arvvoid commented Apr 11, 2019

@Sakerdot got confirmation that this work for HBO Nordic as well #7 with just modifying the URLs.

for spain is api-hboe, for nordic api-hbon and self.API_HOST_GATEWAY = 'https://en.hbonordic.com/'

Copy link
Owner

@arvvoid arvvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes that will make the session persistent, not make it generate a new device uuid on each request, add support for Nordic

hbogolib/handlersp.py Outdated Show resolved Hide resolved
hbogolib/handlersp.py Show resolved Hide resolved
hbogolib/handlersp.py Show resolved Hide resolved
hbogolib/constants.py Outdated Show resolved Hide resolved
hbogolib/handlersp.py Outdated Show resolved Hide resolved
hbogolib/base.py Outdated Show resolved Hide resolved
hbogolib/handlersp.py Outdated Show resolved Hide resolved
hbogolib/handlersp.py Outdated Show resolved Hide resolved
hbogolib/handlersp.py Show resolved Hide resolved
@arvvoid arvvoid changed the title HBO España HBO España + Nordic Apr 18, 2019
@arvvoid arvvoid self-assigned this Apr 18, 2019
@arvvoid
Copy link
Owner

arvvoid commented Apr 18, 2019

New test version for Spain and Nordic please test and report back, please perform all actions and provide debug logs even if all seems to work fine.
[plugin.video.hbogoeu.test.spno.zip REMOVED]

#6 and #7 have been locked for conversation, from now on all conversation regarding HBO Spain and Nordic should be kept here until this is ready to merge.

@PolliSoft
Copy link

PolliSoft commented Apr 18, 2019

Thanks for the test version. Unfortunately it crashes on start, at login. See https://pastebin.com/izZUXkcZ for debug log.
File "C:\Users\Olof\AppData\Roaming\Kodi\addons\plugin.video.hbogoeu\hbogolib\handlersp.py", line 141, in login
"time": time.time()
NameError: global name 'time' is not defined

@arvvoid
Copy link
Owner

arvvoid commented Apr 18, 2019

@PolliSoft tnx for reporting

Fixed version:
plugin.video.hbogoeu.test.spno.zip

@PolliSoft
Copy link

Installed new version, and it works like a charm! No problem with sessions, all videos played as they should (tested around 20 of them).
Still no subtitles.

@macardi
Copy link

macardi commented Apr 18, 2019

Hi, done some testing with the new version. It seems to work fine, no errors.

Logg: https://paste.ubuntu.com/p/3nnVnMdy65/

@jhdgghost
Copy link

Confirmed working hbo spain. But the subtitles are not working

@arvvoid
Copy link
Owner

arvvoid commented Apr 18, 2019

Tnx for reporting.
Like i suspected subtitles are missing from the mpd manifest will have to be handled diferently.
Will get solved just need some time to work on it.
I will need a full debug log from Spain as well to work on the subtitles.

@Sakerdot
Copy link
Contributor Author

Hey, great progress! I haven't had any time, hopefully I'll be able to help more soon.

@jhdgghost
Copy link

01_KODI.log
Here one debug log from hbo spain. I hope i did correctly if not tell me and i try to do again. I check and there is audio options but not subs.

@arvvoid
Copy link
Owner

arvvoid commented Apr 19, 2019

@jhdgghost It's fine, for the future you can follow the steps described here: https://kodi.wiki/view/Log_file/Easy

@arvvoid
Copy link
Owner

arvvoid commented May 7, 2019

Fixed subtitles version:
plugin.video.hbogoeu-esnotest.zip

Tnx @jumakki and tnx @jhdgghost for reporting.

I'm planning of merging this soon will leave it for couple more days, i think this is ready to be used and tested by more people now.
Then the missing features SEARCH, MY LIST, ADD/ROMOVE FROM MY LIST AND VOTING can be added with new pull request/s.
After merging i will start working on the kodi library integration feature.
What you all think about that? @Sakerdot @jumakki

@sanangel
Copy link

sanangel commented May 7, 2019

It works perfectly, although some options are missing, it is more than suitable for daily use.

@Sakerdot
Copy link
Contributor Author

Sakerdot commented May 7, 2019

I've tried it a little bit and it seems fine, I'll have time again by the end of June, hopefully I can help then.

@jumakki
Copy link

jumakki commented May 7, 2019

I agree. It's ready for merging

@arvvoid arvvoid merged commit 7549ecd into arvvoid:master May 8, 2019
@arvvoid
Copy link
Owner

arvvoid commented Oct 28, 2019

@all-contributors please add @Sakerdot for code, ideas

@allcontributors
Copy link
Contributor

@arvvoid

I've put up a pull request to add @Sakerdot! 🎉

@arvvoid
Copy link
Owner

arvvoid commented Oct 28, 2019

@all-contributors please add @PolliSoft for bug, test

@allcontributors
Copy link
Contributor

@arvvoid

I've put up a pull request to add @PolliSoft! 🎉

@arvvoid
Copy link
Owner

arvvoid commented Oct 28, 2019

@all-contributors please add @PolliSoft for bug, test

@allcontributors
Copy link
Contributor

@arvvoid

I've put up a pull request to add @PolliSoft! 🎉

@arvvoid
Copy link
Owner

arvvoid commented Oct 28, 2019

@all-contributors please add @macardi for translation, test

@allcontributors
Copy link
Contributor

@arvvoid

I've put up a pull request to add @macardi! 🎉

@arvvoid
Copy link
Owner

arvvoid commented Oct 28, 2019

@all-contributors please add @jhdgghost for translation, test

@allcontributors
Copy link
Contributor

@arvvoid

I've put up a pull request to add @jhdgghost! 🎉

@arvvoid
Copy link
Owner

arvvoid commented Oct 28, 2019

@all-contributors please add @jumakki for translation, test, bug, ideas

@allcontributors
Copy link
Contributor

@arvvoid

I've put up a pull request to add @jumakki! 🎉

@arvvoid
Copy link
Owner

arvvoid commented Oct 28, 2019

@all-contributors please add @sanangel for testing

@allcontributors
Copy link
Contributor

@arvvoid

I've put up a pull request to add @sanangel! 🎉

@arvvoid
Copy link
Owner

arvvoid commented Oct 28, 2019

@all-contributors please add @alfem for testing

@allcontributors
Copy link
Contributor

@arvvoid

I've put up a pull request to add @alfem! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants