Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress only a subset of types #2129

Merged
merged 13 commits into from
Oct 12, 2022
Merged

Compress only a subset of types #2129

merged 13 commits into from
Oct 12, 2022

Conversation

ahartikainen
Copy link
Contributor

@ahartikainen ahartikainen commented Oct 6, 2022

Fixes #2079

Description

Filter out object dtype from compression.

Checklist

  • Follows official PR format
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@ahartikainen ahartikainen changed the title Dont compress object dtype Don't compress object dtype Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #2129 (8296e50) into main (d4a5eca) will decrease coverage by 0.16%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #2129      +/-   ##
==========================================
- Coverage   90.88%   90.71%   -0.17%     
==========================================
  Files         117      118       +1     
  Lines       12505    12551      +46     
==========================================
+ Hits        11365    11386      +21     
- Misses       1140     1165      +25     
Impacted Files Coverage Δ
arviz/data/inference_data.py 82.95% <80.00%> (-0.05%) ⬇️
arviz/data/converters.py 67.12% <0.00%> (-0.02%) ⬇️
arviz/data/__init__.py 100.00% <0.00%> (ø)
arviz/data/io_beanmachine.py 39.47% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahartikainen
Copy link
Contributor Author

I have not tested timedelta or datetime, but they could probably also work.

https://numpy.org/doc/stable/reference/generated/numpy.dtype.kind.html

@ahartikainen ahartikainen changed the title Don't compress object dtype Compress only a subset of types Oct 10, 2022
@ahartikainen ahartikainen merged commit 3bf643c into main Oct 12, 2022
@ahartikainen ahartikainen deleted the bugfix/text_compression branch October 12, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError when writing to a file with to_netcdf
3 participants