-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed repetitive variable names from forest plots of multivariate variables #1527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @fonnesbeck ! I don't think we need this for more plots -- or maybe plot_parallel ? Curious what the others think.
The test failure is weird, looks like a problem with Azure
How does this look in the case were there are no verbose coords? |
@ahartikainen if the variable is not a multivariate random variable, then it uses the variable name. The only change should be in the multivariate case. |
@AlexAndorra yes, they look like resource provisioning errors. |
Restarting azure and now it seems to run without problem |
Codecov Report
@@ Coverage Diff @@
## main #1527 +/- ##
==========================================
+ Coverage 91.77% 91.79% +0.01%
==========================================
Files 105 105
Lines 11330 11342 +12
==========================================
+ Hits 10398 10411 +13
+ Misses 932 931 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fonnesbeck 🥳
…ariables (arviz-devs#1527) * Removed repetitive variable names in forest plots for mutivariate variables * Removed errant indents * Applied Black formatting * Added changes to CHANGELOG * Fixed multi-chain labelling bug
Forest plots of multivariate variables currently prepend the variable name to each element label, which adds a lot of clutter to the plot. This removes the variable names from all but the first element.
Can add this feature to other plots as needed, either here or in a separate PR.
Not sure what sort of test would be relevant here, if any.
Closes #1524