Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add group info to summary #1408

Merged
merged 5 commits into from
Oct 5, 2020
Merged

add group info to summary #1408

merged 5 commits into from
Oct 5, 2020

Conversation

ahartikainen
Copy link
Contributor

@ahartikainen ahartikainen commented Oct 5, 2020

Description

Add automatic group handling. Defaults to posterior, but works now with InferenceData without posterior (e.g. prior).

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@ahartikainen
Copy link
Contributor Author

I think this is ready.

Do you think 1 group is fine or do we want to enable multiple groups?

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the comment is a minor nit that can be ignored

arviz/stats/stats.py Show resolved Hide resolved
@ahartikainen ahartikainen merged commit 473b34c into master Oct 5, 2020
@ahartikainen ahartikainen deleted the update/summary branch October 5, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants