-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation reorganization #1406
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1406 +/- ##
=======================================
Coverage 91.56% 91.56%
=======================================
Files 105 105
Lines 11097 11098 +1
=======================================
+ Hits 10161 10162 +1
Misses 936 936
Continue to review full report at Codecov.
|
I think this starts to look good already, and being able to use sphinx directives in the notebooks with myst is a game changer, the notebooks can be completely integrated with the rest of the docs (which can now also be written in markdown!), by using toctrees, intersphinx, reference links... Should be ready to review, so I published the preview on my fork: https://oriolabril.github.io/arviz/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't even get everything goes in to that.
Is there something specific we need to remember when we update docs in future.
(Looks great!)
Best thing is that we can keep doing everything exactly like we have been doing so far, however, if we want we can now take advantage of the MyST syntax in order to use sphinx directives from markdown. Some examples:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really awesome, thanks a lot @OriolAbril 👏 🎉 (although I don't understand everything that's going on here, as Ari said 😅 )
I think once we are happy with the new home page we can merge this. I don't really know what I'm doing though, that is, I understand how sphinx handles rst and templates and generates html pages but I don't know what I am doing when writing html nor why thing work (or not), so help will be very appreciated. These last commits show different alternatives of playing with the templates to get a custom layout for the home page. Everything is now set to have as little differences with the current home page as possible, but somehow all the images are shown in a single row (preview not available online, see slack). Not sure if it's something in the html or changes in bootstrap... I also want to note that there is also the option of writing a custom pure html page as home if someone is up for it, I would have no problem integrating it with the rest of the docs. |
I love that we can now use markdown! Still need to check how to use MyST-NB. One comment about the home page I do not really like the vertical gallery, what about removing it? |
We can temporally remove it and open an issue to add the images again. I have managed to divide the page into the correct blocks now (these changes are not pushed to the preview) but I can't get the images to actually fill the space as a grid |
it is a little more similar to the current home page but the grid and the title are quite off
We can merge now! |
Description
Related to #1331. This PR intends to reorganize the documentation in order to make it easier to extend it. There are several important changes to do this:
ref
links and they can useref
,class
,func
... links to refer to other pages.todo list:
Fix gallery generatorThink about pulling relevant docs (i.e. CONTRIBUTING is already included in the docs) such as governance, code of conduct, readme?...I think it's fine for nowEDIT: preview: https://oriolabril.github.io/arviz/index.html
Checklist