Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on plot_pair to plot_kde(InferenceData) ValueError #1218

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

StanczakDominik
Copy link
Contributor

@StanczakDominik StanczakDominik commented Jun 1, 2020

This small text fix adds a reference to plot_pair, rather than just to plot_posterior, when
using plot_kde on InferenceData. This prevents people from trying and failing to use plot_posterior to plot 2D KDEs.

Shoutout and thanks to @OriolAbril, who helped me with finding that function on Gitter :)

Description

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged after updating changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@OriolAbril
Copy link
Member

Thanks for the pull request!

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #1218 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1218   +/-   ##
=======================================
  Coverage   93.14%   93.14%           
=======================================
  Files          94       94           
  Lines        9497     9497           
=======================================
  Hits         8846     8846           
  Misses        651      651           
Impacted Files Coverage Δ
arviz/plots/kdeplot.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec33b4c...c9ed8e3. Read the comment docs.

@OriolAbril OriolAbril merged commit 35affca into arviz-devs:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants