Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in io_pymc3 and add warning for PyMC3<3.9 #1203

Merged
merged 2 commits into from
May 23, 2020
Merged

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented May 23, 2020

Description

bugfix for io_pymc3, there was one self.nchains that should have been self.ndraws. Fixes #1202

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #1203 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1203      +/-   ##
==========================================
- Coverage   93.12%   93.10%   -0.02%     
==========================================
  Files          94       94              
  Lines        9478     9480       +2     
==========================================
  Hits         8826     8826              
- Misses        652      654       +2     
Impacted Files Coverage Δ
arviz/data/io_pymc3.py 92.00% <0.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8676e40...b27d329. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoneType error with standard pymc3 workflow
1 participant