Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcode show=False in plot_posterior subplots #1151

Merged
merged 2 commits into from
Apr 19, 2020
Merged

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Apr 16, 2020

Description

Fix bug in plot_posterior when show rcParam is set to true.

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #1151 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1151   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files          94       94           
  Lines        9286     9286           
=======================================
  Hits         8648     8648           
  Misses        638      638           
Impacted Files Coverage Δ
arviz/plots/backends/matplotlib/posteriorplot.py 98.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e3dcc3...2de3ccc. Read the comment docs.

@canyon289
Copy link
Member

LGTM

@canyon289 canyon289 merged commit a341b66 into master Apr 19, 2020
@OriolAbril OriolAbril deleted the show_rcparam branch April 19, 2020 17:33
nitishp25 added a commit to nitishp25/arviz that referenced this pull request Apr 27, 2020
* added groups

* update tests and changelog

* lint changes

* update from_dict and tests

* update changelog

* modify io_dict

* minor fixes

* update changelog again

Add warning for log scale default in compare/loo/waic functions (arviz-devs#1150)

* Added scale warning to ELPDData

* Added scale warning to compare function

* Added changes to Changelog

* Moved warning to end of string in loo function

* Removed last test for loo_print

* Ran Black

* Integrated Oriol's comments

add local to docstring, and use lowercase for ess (arviz-devs#1152)

hardcode show=False in plot_posterior subplots (arviz-devs#1151)

* hardcode show=False in plot_posterior subplots

* update changelog

Fix documentation and deprecation warning in pair plot (arviz-devs#1156)

The "kind" argument is not described correctly.

* Fix pairplot warning.

Previously, because of incorrect argument checking, pairplot would
mistakenly warn the caller not to use the "contour" argument when that
argument was NOT supplied.  Changed default value to None and did the
defaulting by hand to fix this issue.

Also added some type declarations.

* Clarified docstring for contour argument.

Co-authored-by: Robert P. Goldman <[email protected]>

add viridis as default cmap (arviz-devs#1160)

add examples to customize 2D KDE (arviz-devs#1158)

* add examples to customize 2D KDE

* blackify gallery example

* update changelog

* briefly explain contour_kwargs and contourf_kwargs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants