Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve conversion from Chains to InferenceData #24

Merged
merged 18 commits into from
Nov 21, 2019
Merged

Improve conversion from Chains to InferenceData #24

merged 18 commits into from
Nov 21, 2019

Conversation

sethaxen
Copy link
Member

This PR simplifies and streamlines conversion from Chains to InferenceData. It also fixes the handling of observed_data and constant_data following the schema, adds new functions for creating Dataset, removes mcmcchains_summary from attributes (it breaks serialization with netcdf), and handles concat more safely.

@sethaxen sethaxen changed the title Fixchains Improve conversion from Chains to InferenceData Nov 21, 2019
@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #24 into master will increase coverage by 0.68%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   86.66%   87.35%   +0.68%     
==========================================
  Files           6        6              
  Lines         225      253      +28     
==========================================
+ Hits          195      221      +26     
- Misses         30       32       +2
Impacted Files Coverage Δ
src/utils.jl 51.28% <0%> (-8.18%) ⬇️
src/data.jl 90.19% <100%> (+5.82%) ⬆️
src/mcmcchains.jl 100% <100%> (+1.09%) ⬆️
src/dataset.jl 100% <100%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec1e7e4...31ea17a. Read the comment docs.

@sethaxen sethaxen merged commit 6fff89d into master Nov 21, 2019
@sethaxen sethaxen deleted the fixchains branch November 21, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant