Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to compile RC_1_2 branch in C++20 mode #7491

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Allow to compile RC_1_2 branch in C++20 mode #7491

merged 1 commit into from
Aug 23, 2023

Conversation

Chocobo1
Copy link
Contributor

Previously boost 1.81 reported some errors about parameters should be movable.
Inspired by: 417405f

I suppose this might be breaking ABI. Anyway I'll leave it to arvidn to decide.

@Chocobo1
Allow to compile in C++20 mode
356cefe 
Previously boost 1.81 reported some errors about parameters should be movable.
Inspired by: 417405f
arvidn
arvidn approved these changes Aug 23, 2023
View reviewed changes
Copy link
Owner

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of these types are exported in the public API as far as I can tell, so it shouldn't affect the ABI

@arvidn arvidn merged commit 0a0e80f into arvidn:RC_1_2 Aug 23, 2023
24 checks passed
@Chocobo1 Chocobo1 deleted the cpp20 branch August 24, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@glassez glassez glassez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chocobo1 @arvidn @glassez