Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS arm64 wheels build and tests to .cirrus.yml #7292

Merged
merged 14 commits into from
Feb 11, 2023

Conversation

moodyjon
Copy link
Contributor

Fixes #7131

Does not have any automated pypi upload, but otherwise works for cp39 and cp310 wheels. The artifacts have to be downloaded from Cirrus-CI servers.

https://cirrus-ci.org/guide/writing-tasks/#latest-build-artifacts

Uploading 2 artifacts for /var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cirrus-ci-build/wheelhouse/*
Uploaded /var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cirrus-ci-build/wheelhouse/libtorrent-2.0.8-cp310-cp310-macosx_11_0_arm64.whl
Uploaded /var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cirrus-ci-build/wheelhouse/libtorrent-2.0.8-cp39-cp39-macosx_11_0_arm64.whl

@robd003
Copy link

robd003 commented Jan 31, 2023

@AllSeeingEyeTolledEweSew could you take a look at this?

Jamfile Outdated Show resolved Hide resolved
Jamfile Outdated Show resolved Hide resolved
.cirrus.yml Show resolved Hide resolved
@arvidn
Copy link
Owner

arvidn commented Jan 31, 2023

the new tasks you added don't seem to be running right. At least they're not green.

@robd003
Copy link

robd003 commented Jan 31, 2023

@arvidn it looks like tasks need approval before they'll run

@arvidn
Copy link
Owner

arvidn commented Jan 31, 2023

usually github doesn't show tasks as grey before approved though, but maybe cirrus is different. I just triggered one manually, and now it's green. the main task still ran and was green.

@arvidn
Copy link
Owner

arvidn commented Jan 31, 2023

"Build macOS arm64 wheels" did not seem to have triggered by me approving and running tests.

.cirrus.yml Outdated

build_macos_arm64_task:
name: Build macOS arm64 wheels.
trigger_type: manual
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, this is why these workflows don't run. did you mean to make these manual/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it manual based on this comment:
#7131 (comment)

The trigger_type seems to only support manual. There are also options to restrict it to monitor certain organizations, repositories, branches, etc. I haven't found an option that runs a task specifically on pull requests.

I want to be sure the setting doesn't end up triggering too many runs per day... wouldn't want to be the one that ruins the free M1 runner pool.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you just remove the trigger type field, and have it behave like the other cirrus jobs, I believe it would only run on pushes.
if it doesn't run on every PR, it's likely to break at some point without anyone noticing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@moodyjon
Copy link
Contributor Author

moodyjon commented Feb 10, 2023

To download artifacts (wheels.zip) you visit the GitHub page for the task status of "Build macOS arm64 wheels", then click View more details on Cirrus CI.

@arvidn
Copy link
Owner

arvidn commented Feb 11, 2023

looks good. the next step would be to hook this up to the cibuildwheel workflow that I trigger when releasing. That job currently uploads packages to pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python binding for macOS aarch64 fails to install
3 participants