Infinite loop in mutex dtor when backend is unavailable #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is another issue (infinite loop) with the mutex destructor. It occurs when the lock backend service is unavailable at release time. The loop in destructor should take in account the releaseLock()'s return value (ie release status) and stop its processing in case of release failure. I have chosen to throw an exception in this case.
There is also a consistency break between "counter" and "acquired" bit which always means counter == 0 so I have removed this one.
This patch is splitted into 2 commits. The first is the unit test which proves the failure (no throw) when the backend is unavailable and the second is the fix.