Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markdown-it to v12 #114

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Update markdown-it to v12 #114

merged 1 commit into from
Dec 31, 2020

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented Nov 10, 2020

Also fixes #113 by adding a blank line after the table in a test. The new behavior in markdown-it v12 is correct according to GitHub Flavored Markdown Spec. The blank line works the same way in markdown-it versions 9 through 11 too.

Fixes #113 by adding a blank line after the table in a test.
@janosh
Copy link

janosh commented Dec 23, 2020

Thanks @valtlai! Could this be merged?

@arve0 arve0 merged commit feec9f1 into arve0:master Dec 31, 2020
@arve0
Copy link
Owner

arve0 commented Dec 31, 2020

Released in v4.0.0.

@arve0
Copy link
Owner

arve0 commented Dec 31, 2020

Thanks :octocat: Sorry for the late merge, a lot has happened since november 👶🏻

@valtlai
Copy link
Contributor Author

valtlai commented Jan 1, 2021

Thanks for merging and congrats! 🙂

@valtlai valtlai deleted the mdi-v12 branch January 1, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tables break in markdown-it v12
3 participants