Fix microsoft#10108 (Completion suggestion for object literal with ge…

…tter)
arusakov · Oct 24, 2016 · 40e0fc7 · 40e0fc7
1 parent cef9d85
commit 40e0fc7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -1590,7 +1590,8 @@ namespace ts.Completions {
                 if (m.kind !== SyntaxKind.PropertyAssignment &&
                     m.kind !== SyntaxKind.ShorthandPropertyAssignment &&
                     m.kind !== SyntaxKind.BindingElement &&
-                    m.kind !== SyntaxKind.MethodDeclaration) {
+                    m.kind !== SyntaxKind.MethodDeclaration &&
+                    m.kind !== SyntaxKind.GetAccessor) {
                     continue;
                 }
 

diff --git a/tests/cases/fourslash/server/completions03.ts b/tests/cases/fourslash/server/completions03.ts
@@ -0,0 +1,17 @@
+/// <reference path="../fourslash.ts"/>
+
+// issue: https://github.com/Microsoft/TypeScript/issues/10108
+
+//// interface Foo {
+////    one: any;
+////    two: any;
+//// }
+////
+//// let x: Foo = {
+////     get one() { return "" },
+////     /**/
+//// }
+
+goTo.marker("");
+verify.completionListContains("two");
+verify.not.completionListContains("one");