Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to split links depending on mode #247

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Conversation

KasiaKoz
Copy link
Collaborator

@KasiaKoz KasiaKoz commented Nov 12, 2024

Closes: #244, second in a series of 3, to facilitate better active mode support

@KasiaKoz KasiaKoz requested review from mfitz and gac55 November 12, 2024 13:07
Copy link
Contributor

@mfitz mfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like the unit tests - concise and clear.

I've asked a couple of questions inline, but there's nothing crucial.

src/genet/core.py Show resolved Hide resolved
tests/test_core_network.py Outdated Show resolved Hide resolved
tests/test_core_network.py Outdated Show resolved Hide resolved
tests/test_core_network.py Show resolved Hide resolved
- add a step to example in docstring
- refine assertions in tests
@KasiaKoz KasiaKoz merged commit 8f35b8c into main Nov 13, 2024
12 checks passed
@KasiaKoz KasiaKoz deleted the feature/split-links-on-mode branch November 13, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method to split links of mode for core Network object
2 participants