Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace branch approach by monorepo #55

Closed
wants to merge 20 commits into from
Closed

Replace branch approach by monorepo #55

wants to merge 20 commits into from

Conversation

lucleray
Copy link

@lucleray lucleray commented Feb 12, 2019

  • each lesson is a folder (each item in the next-site/learn sidebar is a folder, with the exception of getting started)
  • update dependencies to latest
  • add prettier to fix formatting conflicts
  • it is not needed anymore to stop/start next
  • add readme to the repository explaining how to clone/download the repo
  • fix 'url' property is deprecated
  • add name to unnamed components
  • use functions instead of arrow functions

todo :

  • fix this issue in E2-firebase-hn
  • create PR with appropriate changes in next-site/learn

room for improvement:

  • add cross-env for NODE_ENV=production node server.js
  • replace webpack-bundle-analyzer by @zeit/next-bundle-analyzer
  • lazy loading components lesson needs to be updated

fixes #26
fixes #24

@timneutkens
Which one do you prefer:

  • the content of a folder is what is expected at the end of the lesson (e.g. 1-getting-started contains what you get when you're done with the Getting Started lesson)
  • the content of a folder is what you should start with at the beginning of a lesson (e.g. 2-using-shared-components contains the files to start the Using shared components lesson)

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@lucleray
Copy link
Author

lucleray commented Jun 5, 2019

I'm closing this because there is a new repo for it here : https://github.com/zeit/next-learn-demo

@lucleray lucleray closed this Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot npm i Lazy Loading Modules tutorial Error while loading page which fetches data from an API call
2 participants