Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some functions are not inline #43

Open
klosworks opened this issue Jul 14, 2019 · 1 comment
Open

some functions are not inline #43

klosworks opened this issue Jul 14, 2019 · 1 comment

Comments

@klosworks
Copy link

Some functions are not inline. This will cause multiple definition errors in projects that include your lib.
Examples:

  std::string get_last_error()
  FILE *file_from_handle(HANDLE h, const char *mode)
void configure_pipe(HANDLE* read_handle, HANDLE* write_handle, HANDLE* child_handle)

There is already an issue #34, but it is about a specific function and you have a more general problem.

@deanmsands3
Copy link
Contributor

Submitted Pull Request #59 .

arun11299 pushed a commit that referenced this issue Sep 29, 2020
* Issue 43: some functions are not inline

* Issue #60: MinGW support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants