Skip to content

Commit

Permalink
server: delete TestIntentResolution
Browse files Browse the repository at this point in the history
This is an old test which is tightly coupled with how locks are tracked
on the client. In particular, it expects all ranged locking requests to
use `ResolveIntentRange` requests to resolve their locks; this is
expected to change immminently (see cockroachdb#121086). It's also cumbersome to
change given the randomization it uses to construct batches.

We've got coverage for things being tested here elsewhere. There's some
integration tests in `intent_resolver_integration_test.go` that test
things deterministically. There's also tests for the txn pipeliner and
txn committer that test lock tracking on the client. I'm probably
missing some other examples as well, but deleting this should be safe.

Epic: none

Release note: None
  • Loading branch information
arulajmani committed Mar 26, 2024
1 parent 165e769 commit 2118a72
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 190 deletions.
3 changes: 0 additions & 3 deletions pkg/server/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,6 @@ go_test(
"grpc_gateway_test.go",
"helpers_test.go",
"index_usage_stats_test.go",
"intent_test.go",
"job_profiler_test.go",
"load_endpoint_test.go",
"main_test.go",
Expand Down Expand Up @@ -488,7 +487,6 @@ go_test(
"//pkg/kv/kvpb",
"//pkg/kv/kvserver",
"//pkg/kv/kvserver/closedts",
"//pkg/kv/kvserver/kvserverbase",
"//pkg/kv/kvserver/kvserverpb",
"//pkg/kv/kvserver/kvstorage",
"//pkg/kv/kvserver/liveness/livenesspb",
Expand Down Expand Up @@ -550,7 +548,6 @@ go_test(
"//pkg/util/protoutil",
"//pkg/util/randutil",
"//pkg/util/stop",
"//pkg/util/syncutil",
"//pkg/util/timeutil",
"//pkg/util/tracing",
"//pkg/util/tracing/tracingpb",
Expand Down
187 changes: 0 additions & 187 deletions pkg/server/intent_test.go

This file was deleted.

0 comments on commit 2118a72

Please sign in to comment.