MRC-1631 - Directions Beta, add step by step support to the multi-floor demo #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vercasson
commented
Aug 14, 2023
•
vercasson
commented
- This change is documented in CHANGELOG.md
vercasson
changed the title
tarakreft
approved these changes
Aug 18, 2023
| @@ -73,7 +73,7 @@ const OverlayMarker: FunctionComponent<OverlayMarkerProps> = ({ | |||
| fill={fill} | |||
| fill-opacity={fillOpacity} | |||
| stroke={stroke} | |||
| stroke-width={strokeWidth / mapZoomFactor} | |||
There was a problem hiding this comment.
why doesn't this need the mapZoomFactor anymore?
There was a problem hiding this comment.
markers don't need this
| floorID: map_id, | ||
| steps: [], | ||
| }; | ||
| function stepsToPolygonPoints(steps, mapID) { |
There was a problem hiding this comment.
I'm curious why all these functions (stepsToPolygonPoints, generateRouteOverlays, etc) are defined in the demo. I would expect there to be functions that a user can call in the webSdk and then the demo shows users how to leverage the functions to build their overlays.
There was a problem hiding this comment.
These will most likely be checked in at one point. Not ready for that yet.
amyhliao
approved these changes
Aug 18, 2023
| strokeWidth: 8, | ||
| strokeLineJoin: "round", | ||
| strokeLineCap: "round", | ||
| // markerStart: "url(#arrow)", |
There was a problem hiding this comment.
LGTM, are these comments needed?
| } else { | ||
| return { | ||
| }, | ||
| // { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.