-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve conflict #123
Merged
Merged
Resolve conflict #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natioal check digit
Bumps [junit](https://github.com/junit-team/junit4) from 4.11 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.11.md) - [Commits](junit-team/junit4@r4.11...r4.13.1) Signed-off-by: dependabot[bot] <[email protected]>
- remove deprecated parent pom - bump java version to 1.8 - add maven wrapper - bump versions - change broken project URL to GitHub project URL - add maven wrapper
Added correct BbanStructure for Gabon and included Test case
Co-authored-by: Remy Duval <[email protected]>
* update junit version to 5 * update junit version to 5 * test cases refactored * test cases refactored * test cases refactored * test cases refactored to new class * test cases refactored * test cases refactored * test cases refactored * Parametrized test cases refactored * Hamcrest test cases refactored * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case * fixing test case
* testing github action * testing github action java * testing github action java * testing github action * testing github action * testing github action
* testing github action * testing github action java * testing github action java * testing github action * testing github action * testing github action * testing github action
* testing github action * testing github action java * testing github action java * testing github action * testing github action * testing github action * testing github action * update java adopt jdk badge
* update java adopt jdk badge * adding non default padded character * adding branch code to use padding left * change the README.md * release 3.2.6-RELEASE
* add GHA for maven verify * add GHA for maven verify * add test report step * experimenting with some other reporting actions * tweaking GHA * tweaking GHA * tweaking GHA * tweaking GHA * rm broken/buggy test report actions * try fixing jacoco report * rm jacoco report upload * rm jacoco report upload * rm jacoco report upload
deleted because of new ci yml
* Adding Cap Verde structure * Adding tests for CV --------- Co-authored-by: RHoog <[email protected]>
* fix spelling mistake, ibanContruction -> ibanConstruction * add overload to allow passing a custom Random - add toString() to BbanStructureEntry.java - tests to check if randomness is deterministic - add additional tests for validity of BbanStructureEntry.java - TODO figure out if 'c' can generate a-z * remove TODO - a-z is not required * fix code suggestions/warnings * update tests to JUnit5 * remove duplicated `ibanConstructionRandom()` test * update assertions * fix test name after merge * update expected random values * re-add accidentally removed test --------- Co-authored-by: aSemy <[email protected]>
# Conflicts: # pom.xml # src/test/java/org/iban4j/IbanTest.java
Added correct BbanStructure for Gabon and included Test case
* testing github action * testing github action java * testing github action java * testing github action * testing github action * testing github action
deleted because of new ci yml
Added correct BbanStructure for Gabon and included Test case
* testing github action * testing github action java * testing github action java * testing github action * testing github action * testing github action
deleted because of new ci yml
…mote-sync # Conflicts: # pom.xml # src/test/java/org/iban4j/IbanTest.java
Fetch remote sync
Added correct BbanStructure for Gabon and included Test case
* testing github action * testing github action java * testing github action java * testing github action * testing github action * testing github action
deleted because of new ci yml
hajk1
commented
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to check the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.