-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for security context #87
Conversation
@arttor this PR should be ready for review :) |
@mowies looks really nice and ready to merge. i am just thinking is there any case when chart maintainer doesn't want securityContext to be modified. In this case we should add flag and add securityContext to template only if it is enabled. what do you think? |
I don't really see a use case for the CLI flag honestly.. I think if you have the security context set up, you will probably also want to show those values in the helm chart. Maybe we can leave that for now and see if users request it in the future? |
@mowies can you please update your branch? i cannot merge pr due to conflicts |
@arttor done |
@mowies still can't |
strange, i still can't merge. can you try to rebase main? |
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
ok, all done. seem that some examples were not fully re-generated with the last PR. I regenerated both the operator and the sample app again. |
@mowies thank you! Your changes are available in v0.3.29 release |
This PR