Add an option for enable/disable webhook for a standard operator generated by kubebuilder #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashanji
force-pushed
the
add-enable-webhook-option
branch
from
4ae4f03 to
826e4c4
Compare
|
@arttor Hi, could you please take a look at this? Thanks. |
dashanji
force-pushed
the
add-enable-webhook-option
branch
from
826e4c4 to
b4f8439
Compare
|
Hi @dashanji, I am very sorry. Will only have time to check on the weekend. |
arttor
requested changes
Apr 16, 2023
|
Hi @arttor, could you please take a look at this? Thanks. |
dashanji
force-pushed
the
add-enable-webhook-option
branch
3 times, most recently
from
bcac65f to
d6f44f3
Compare
|
Can we revive this, I also require this use case |
|
yep, can do a review but now branch has some conflicts and should be updated |
dashanji
force-pushed
the
add-enable-webhook-option
branch
2 times, most recently
from
200d02e to
b93c699
Compare
|
Hi @arttor, I have fixed the conflict. Could you please take a look at this? |
arttor
approved these changes
Nov 17, 2024
|
@dashanji there is still conflicts with main after merging bugfix |
…nerated by kubebuilder. * Use regular expressions to match the containerPort of the webhook. Signed-off-by: Ye Cao <[email protected]>
dashanji
force-pushed
the
add-enable-webhook-option
branch
from
b93c699 to
9487780
Compare
Done. |
arttor
approved these changes
Nov 17, 2024
|
The changes are available in v0.4.15 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled. Fix #57.