Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Calibre Webhook #81

Merged
merged 1 commit into from
May 20, 2021
Merged

feature: Calibre Webhook #81

merged 1 commit into from
May 20, 2021

Conversation

icirellik
Copy link
Contributor

Adds a webhook that accepts metrics from Calibre and forwards them to
DataDog.

@icirellik icirellik force-pushed the feature-calibre-webhook branch 2 times, most recently from ad917c0 to 90c7fb1 Compare May 19, 2021 17:48
joeyAghion
joeyAghion approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@joeyAghion joeyAghion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, it would be more hygienic and easier to review if the Typescript migration was separated from the new endpoint, but I understand that's difficult at this point.

src/app/calibreWebhookRoute.ts Outdated Show resolved Hide resolved
@icirellik
feature: Calibre Webhook
f636cfb 
Adds a webhook that accepts metrics from Calibre and forwards them to
DataDog.
@icirellik icirellik merged commit 1470aeb into master May 20, 2021
@icirellik icirellik deleted the feature-calibre-webhook branch May 20, 2021 14:46
@artsy-peril artsy-peril bot mentioned this pull request May 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyAghion joeyAghion joeyAghion approved these changes

@izakp izakp izakp approved these changes

@jonallured jonallured Awaiting requested review from jonallured

Assignees

@izakp izakp

Labels
Merge On Green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icirellik @joeyAghion @izakp