@kanaabe: Refactored article component to fix fullscreen slideshow #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@craigspaeth Looks like these web pack bundles are missing babel-polyfill, but that should be fixed in newer storybook versions, so try upgrading to the latest version? |
kanaabe
approved these changes
Oct 12, 2017
|
I'll follow up PR with the polyfill stuff. Thanks Eloy + Kana! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the slideshow was simply using
childContextTypesin the child component vs.contextTypesbut I also decided to loop in the refactors from the last PR.I can't find a way to use the simulator to test the mobile tap issue you encountered because of the un-pollyfilled advanced browser features Reaction uses. Maybe @alloy or @orta has an idea of how to do this? Barring a way to locally test this should allow us to test on GH pages atleast.