Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused error check #1228

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Remove unused error check #1228

merged 1 commit into from
Aug 15, 2017

Conversation

damassi
Copy link
Member

@damassi damassi commented Aug 15, 2017

(We don't actually need that typecheck :)

@damassi damassi self-assigned this Aug 15, 2017
@damassi damassi merged commit a4faf5c into artsy:master Aug 15, 2017
@damassi damassi deleted the quickfix-error branch August 15, 2017 19:01
@artsy-peril
Copy link
Contributor

artsy-peril bot commented Aug 15, 2017 •
edited
Loading

Fails
🚫

Could not find a Dangerfile at

Full state of PR run:

{
  "branch": "quickfix-error",
  "dangerfileBranchForPR": "quickfix-error",
  "neededDangerfileIsSameRepo": false,
  "repoForDangerfile": "damassi/positron",
  "run": {
    "event": "pull_request",
    "action": "closed",
    "dslType": 0,
    "dangerfilePath": "dangerfile.js",
    "feedback": 0
  },
  "settings": {
    "commentableID": 1228,
    "hasRelatedCommentable": true,
    "isRepoEvent": true,
    "isTriggeredByUser": true,
    "repo": {
      "fullName": "artsy/positron",
      "id": 111,
      "installationID": 1,
      "rules": {
        "pull_request": "dangerfile.js"
      }
    },
    "repoName": "artsy/positron",
    "triggeredByUsername": "damassi"
  }
}

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@damassi damassi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@damassi