Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@kanaabe => Save blockquote as section layout #1220

Merged
merged 1 commit into from
Aug 11, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/apps/articles/model/schema.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ denormalizedArtwork = (->
@object().meta(name: 'Text').keys
type: @string().valid('text')
body: @string().allow('', null)
layout: @string().allow('blockquote', null)
@object().meta(name: 'Artworks').keys
type: @string().valid('artworks')
ids: @array().items(@string().objectid())
Expand Down
16 changes: 16 additions & 0 deletions api/apps/articles/test/model/save.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,22 @@ describe 'Save', ->
]
})

it 'can save layouts on text sections', (done) ->
Save.sanitizeAndSave( ->
Article.find '5086df098523e60002000011', (err, article) =>
article.sections[0].layout.should.eql 'blockquote'
done()
)(null, {
_id: ObjectId '5086df098523e60002000011'
sections: [
{
type: 'text'
body: '<blockquote>Viva Art</blockquote>'
layout: 'blockquote'
}
]
})

it 'indexes articles that are indexable', (done) ->
Save.sanitizeAndSave( =>
Article.find '5086df098523e60002000011', (err, article) =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ module.exports = React.createClass
className: 'edit-section__container'
'data-editing': @props.editing
'data-type': @props.section.get('type')
'data-layout': @props.section.getLayout(@props.article.get('layout'))
'data-layout': @props.section.get('layout') or 'column_width'
},
unless @props.section.get('type') is 'fullscreen'
div {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
border-radius 50%

.classic
[data-layout='column_width']
[data-layout='column_width'], [data-layout='blockquote']
max-width classic-body-w-margin
margin 0 auto
[data-layout='overflow_fillwidth']
Expand All @@ -82,7 +82,7 @@
[data-layout='column_width']
max-width standard-body-w-margin
margin 0 auto
[data-layout='overflow_fillwidth']
[data-layout='overflow_fillwidth'], [data-layout='blockquote']
max-width standard-overflow-w-margin

.feature
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,15 +217,18 @@ module.exports = React.createClass
blockquote = blockquote.replace(beforeBlock, '')
@props.sections.add {type: 'text', body: beforeBlock}, {at: @props.index }
increment = 1
@props.section.set('body', blockquote)
@props.section.set({body: blockquote, layout: 'blockquote'})
@props.onSetEditing @props.index + increment

toggleBlockType: (blockType) ->
unless blockType is 'blockquote' and [email protected]
@onChange RichUtils.toggleBlockType(@state.editorState, blockType)
@setState showMenu: false
if blockType is 'blockquote'
@toggleBlockQuote() if @props.section.get('body').includes('<blockquote>')
if @props.section.get('body').includes('<blockquote>')
@toggleBlockQuote()
else
@props.section.set('layout', null)
return 'handled'

toggleInlineStyle: (inlineStyle) ->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ describe 'Section Text', ->
@shortComponent.setState = sinon.stub()
r.simulate.mouseDown r.find @shortComponent, 'blockquote'
@shortComponent.setState.args[0][0].html.should.eql '<blockquote>A <em>short</em> piece of <strong>text</strong></blockquote>'
@shortComponent.props.section.get('layout').should.eql 'blockquote'

it '#makePlainText Can strip styles', ->
r.simulate.mouseUp r.find @shortComponent, 'edit-section--text__input'
Expand Down Expand Up @@ -336,6 +337,7 @@ describe 'Section Text', ->
@shortComponent.setState = sinon.stub()
@shortComponent.handleKeyCommand('blockquote')
@shortComponent.setState.args[0][0].html.should.eql '<blockquote>A <em>short</em> piece of <strong>text</strong></blockquote>'
@shortComponent.props.section.get('layout').should.eql 'blockquote'

it 'Cannot toggle Blockquotes if hasFeatures is false', ->
@shortComponent.setState hasFeatures: false
Expand Down
2 changes: 1 addition & 1 deletion client/components/drag_drop/index.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ module.exports = React.createClass
i = child.props.index or i
type = child.props.section?.get('type') or null
if child.type.displayName is 'SectionContainer'
layout = child.props.section.getLayout(@props.article?.get('layout'))
layout = child.props.section.get('layout') or 'column_width'
DragTarget {
key: i
i: i
Expand Down
8 changes: 0 additions & 8 deletions client/models/section.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,3 @@ module.exports = class Section extends Backbone.Model
_.extend super, ids: @artworks.pluck '_id'
else
super

getLayout: (articleLayout) ->
layout = 'column_width'
if @get('type') is 'text' and @get('body')?.includes('<blockquote>')
layout = if articleLayout is 'feature' then 'blockquote' else 'overflow_fillwidth'
else if @get('layout')
layout = @get('layout')
return layout
23 changes: 0 additions & 23 deletions client/test/models/section.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -64,26 +64,3 @@ describe "Article", ->
it 'extracts a slug from a Google link', ->
@section.set body: '<p><a href="https://www.google.com/url?q=https%3A%2F%2Fwww.artsy.net%2Fartist%2Ftrenton-doyle-hancock&sa=D&sntz=1"></p>'
@section.slugsFromHTML('body','artist')[0].should.equal 'trenton-doyle-hancock'

describe '#getLayout', ->

it 'returns column width by default', ->
layout = @section.getLayout()
layout.should.eql 'column_width'

it 'can return an existing layout', ->
@section.set layout: 'fullscreen'
layout = @section.getLayout()
layout.should.eql 'fullscreen'

it 'returns overflow if blockquote', ->
@section.set type: 'text'
@section.set body: '<blockquote>Cool pullquote</blockquote>'
layout = @section.getLayout()
layout.should.eql 'overflow_fillwidth'

it 'returns blockquote if feature article', ->
@section.set type: 'text'
@section.set body: '<blockquote>Cool pullquote</blockquote>'
layout = @section.getLayout('feature')
layout.should.eql 'blockquote'