-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a check for PRs on Metaphysics that production is up-to-date with staging for dependent repos #86
Conversation
Updated Because the aws-sdk isn't written in Typescript and doesn't define any interfaces for its methods, I had some problems manipulating the
to be able to return 'any' from I'm a bit confused about the scope of what this PR is meant to achieve and what to implement in the the default export function @orta @joeyAghion - should it compare the schemas for Metaphysics at both |
I think comparing the image tags for production and staging to be the same should probably be enough. I feel like it can skip the schema checking TBH because then it can be expanded to work with any service and not just our GraphQL apis. 👍 |
I'm not sure I follow the staging/production comparison idea. Requiring Metaphysics' staging and production to be the same is too strict (schema additions in staging should be acceptable). Are you talking about requiring that of upstream APIs (sources)? The original intent as described in artsy/README#109 was to ensure that the schema required by a PR (according to the committed |
@orta @joeyAghion well, given there is some disagreement here I generalized the
|
Note that this will require IAM credentials present in Danger's runtime environment, with permissions set for the |
I feel like this implementation is not addressing artsy/README#109 so I am going to close for now until we can spec a clearer implementation - @orta please don't bother with adding the IAM credentials to Peril's runtime either |
Re: artsy/README#109
This is now unblocked because the AWS SDK is now available to Peril
danger/peril@a46c62e, and I can use that to grab the images to compare them.