fix: avoid serialization / deserialization of request body to query string and back #6333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paired with @dblandin on this one. This is not a final PR, just a proposal / conversation starter:
When working on #6331 we've noticed that when we send POST / PUT / DELETE requests with some data in them, the data is being converted (here, but it's not very obvious to understand) to query string params, and then back (here) before sending this data to the next service. Basically when we do
gravityLoader('/something', { some: 'data' }), the data will be temporarily converted to/something?some=data. In most cases, this is not a problem.But apparently it can be a problem sometimes, like, for example, with this issue mentioned above. @dblandin and I are wondering - should PPST / PUT / DELETE requests completely skip this weird intermediate step?