Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@alloy: Use forever and max_old_space size to cap memory usage #482

Merged
merged 4 commits into from
Dec 2, 2016

Conversation

craigspaeth
Copy link
Contributor

Adds the --max_old_space_size flag to cap memory usage in Heroku, see nodejs/node#3370. Also added forever for good measure to restart on crashes.

@alloy
Copy link
Contributor

alloy commented Nov 30, 2016

In Slack you had pointed me to the Makefile, why is this PR different?

@alloy
Copy link
Contributor

alloy commented Nov 30, 2016

CI is 🔻 regarding installation of yarn. Does it need a rebuild without cache or something?

@alloy
Copy link
Contributor

alloy commented Nov 30, 2016

I also don’t see an update to the yarn.lock file, you should check-in those changes.

@craigspaeth
Copy link
Contributor Author

Oh right, I forgot we're using Yarn now. Will update.

We used a Makefile in Force b/c that was one of the popular ways to do it at the time Force was born. Nowadays it's more common to just use the package.json scripts field like we, mostly, do here. The only other thing we're also using here is Foreman + Procfiles to load a .env file and run different commands for dev/production. FWIW we can further consolidate this to just a package.json file by using dotenv.

... so many finicky build tool ideas in Node land.

@alloy
Copy link
Contributor

alloy commented Nov 30, 2016

Ooowww… It’s totally my bad, I didn’t realise I was looking at Force’s codebase, not metaphysics 😞 Thanks for clearing that up!

@alloy
Copy link
Contributor

alloy commented Dec 1, 2016

@orta Do you have any ideas from the top of your head about this CI failure re yarn installation?

@orta
Copy link
Contributor

orta commented Dec 2, 2016

Fixed 👍

@craigspaeth
Copy link
Contributor Author

Thanks Orta!

@craigspaeth craigspaeth merged commit eea3110 into artsy:master Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants