Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolchain: Parallelize Jest tests on CI #3094

Merged
merged 2 commits into from
Apr 15, 2021
Merged

toolchain: Parallelize Jest tests on CI #3094

merged 2 commits into from
Apr 15, 2021

Conversation

damassi
Copy link
Member

@damassi damassi commented Apr 14, 2021 •
edited
Loading

Addresses https://artsyproduct.atlassian.net/browse/FP-25

This PR splits our Jest tests into two separate jobs -- v1 and v2 -- so that old code and new can run in parallel and speed up CI runs.

Process:

  • Took existing config and copied it to a jest.v2 config file
  • Created jest.v1 file and scoped the test runner only to tests within v1 folders

Before:

  • ~22min

After:

  • ~6min

🎉

@damassi damassi self-assigned this Apr 14, 2021
@damassi damassi force-pushed the damassi/parallelize-tests branch 8 times, most recently from 8e07e1a to ae83ef3 Compare April 14, 2021 23:28
@damassi damassi assigned zephraph and unassigned damassi Apr 14, 2021
@damassi damassi requested a review from joeyAghion April 14, 2021 23:30
zephraph
zephraph reviewed Apr 15, 2021
View reviewed changes
package.json Show resolved Hide resolved
zephraph
zephraph reviewed Apr 15, 2021
View reviewed changes
package.json Show resolved Hide resolved
zephraph
zephraph approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@zephraph zephraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got some comments/feedback, but I don't think anythings particularly blocking. We should watch this, we might get spurious failures. There should be a conversation (on platform?) about code coverage.

In the spirit of impact over perfection, I'm 👍

@zephraph zephraph merged commit 42b20dc into master Apr 15, 2021
@zephraph zephraph deleted the damassi/parallelize-tests branch April 15, 2021 15:16
@artsy-peril artsy-peril bot mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zephraph zephraph zephraph approved these changes

@joeyAghion joeyAghion Awaiting requested review from joeyAghion

Assignees

@zephraph zephraph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damassi @zephraph