feat: label review app namespaces #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artsyjian
force-pushed
the
artsyjian/reviewapp
branch
2 times, most recently
from
bac005e to
44a2e3c
Compare
artsyjian
force-pushed
the
artsyjian/reviewapp
branch
from
44a2e3c to
89f2229
Compare
artsyjian
commented
Aug 18, 2023
| ``` | ||
| python -m setuptools_scm | ||
| ``` | ||
|
|
There was a problem hiding this comment.
if this command is not run, hokusai version reports v0.0.0 (the dummy string in pyproject.toml). that causes conflict with projects that require certain versions of Hokusai (e.g. hokusai-sandbox).
artsyjian
commented
Aug 18, 2023
| 'name': clean_string(app_name) | ||
| 'name': clean_string(app_name), | ||
| 'labels': { | ||
| 'app-phase': 'review' |
There was a problem hiding this comment.
potentially another use case for a ~/.hokusai.conf config file. i would have a var there like org=acme, then this label can become acme/app-phase: review which should never conflict with any label k8s might automatically add to this resource in the future.
mc-jones
approved these changes
Aug 21, 2023
|
thanks it should be good to merge. |
This was referenced Aug 25, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports PHIRE-179
We have a script that cleans up old Review Apps. It does so by deleting their Kubernetes namespaces.
The script must know which namespaces are Review Apps. Currently there is no way to determine that from the name of a namespace. Therefore, the script is hardcoded with a list of non-Review-App namespaces and it deletes namespaces not on that list.
However, the list has become a burden to upkeep. This PR proposes to label Review App namespaces with
app-phase=review. This allows the script to filter namespaces by that label, then we can do away with the non-Review-App list.Un-related fix:
setuptools_scmfor local dev.