Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android download mobile footer #7656

Merged
merged 6 commits into from
May 28, 2021

Conversation

anastasiapyzhik
Copy link
Contributor

@anastasiapyzhik anastasiapyzhik commented May 28, 2021

I united 2 subtasks in 1 PR because they use the same logic of device detecting.

https://artsyproduct.atlassian.net/browse/GRO-341

Before
Screen Shot 2021-05-28 at 3 03 10 PM

After
Screen Shot 2021-05-28 at 3 04 44 PM

Screen Shot 2021-05-28 at 3 05 16 PM

https://artsyproduct.atlassian.net/browse/GRO-343

Before
Screen Shot 2021-05-28 at 5 35 23 PM

After
Screen Shot 2021-05-28 at 5 36 00 PM

@anastasiapyzhik anastasiapyzhik requested a review from a team May 28, 2021 12:06
@anastasiapyzhik anastasiapyzhik changed the title Add android download mobile footer draft: Add android download mobile footer May 28, 2021
@anastasiapyzhik anastasiapyzhik changed the title draft: Add android download mobile footer Add android download mobile footer May 28, 2021
Copy link
Member

@damassi damassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 👌

@damassi damassi merged commit b0e4f64 into master May 28, 2021
@damassi damassi deleted the anastasiapyzhik/add-android-download-mobile-footer branch May 28, 2021 16:29
@artsy-peril artsy-peril bot mentioned this pull request May 28, 2021
}, [])

return { device, downloadAppUrl }
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably introduce a default state here — this introduces a page shift since it only returns something useful on client-load

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants