Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SEO meta for Buyer Guarantee #7648

Merged
merged 2 commits into from
May 27, 2021
Merged

fix: SEO meta for Buyer Guarantee #7648

merged 2 commits into from
May 27, 2021

Conversation

ashleyjelks
Copy link
Contributor

#7646 was merged before the leading whitespace in the meta tag description was removed. It seems to be causing an issue on CI so the original branch was reverted 5a02c56 and this PR fixes the whitespace issue.

@ashleyjelks ashleyjelks requested a review from a team May 27, 2021 15:53
@ashleyjelks ashleyjelks self-assigned this May 27, 2021
@ashleyjelks ashleyjelks added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label May 27, 2021
@artsy-peril artsy-peril bot merged commit 5ae1e1b into master May 27, 2021
@artsy-peril artsy-peril bot deleted the seo-meta-bg-fix branch May 27, 2021 16:00
@artsy-peril artsy-peril bot mentioned this pull request May 27, 2021
The-Beez-Kneez added a commit that referenced this pull request May 27, 2021
* draft: Added A-Z letters to artists nav bar on hover

* refactor: ArtistsLetterNav props

* Aligned 'View all artists' and 'Browse by name' lines. Widened letters

* feat: Added A-Z letters to mobile

* feature: Webpack Chunking

* Reduces the number of sub KiB bundles by using V2 application scope as
  the common denominator.
* Restricts bundles to 240 KiB unzipped
* Cleans up legacy imports accidentally included by the orders page.

* GRO-336: Implement IP address tracking solution in Force  (#7582)

* Extract local for initial values

* Sort formik bag

* Extract locals for error messages

* Sort things when you can

* Simplify terms checkbox

* Simplify email checkbox

* Collapse sign up options when possible

* Split up the terms labels

* Grab ip address for sign up lookup

* Update tests for sign up form

* Added TODO and moved scoped out Sign Up tests that will be covered in Cyprus Integration testing

* Added readonly

* Updated FormSwitcher jest tests for new SignUpFormQueryRenderer

* Update name of sharify helper

* Provide fallback for request ip

* Mock misbehaving render

Co-authored-by: Jon Allured <[email protected]>

* feat: Add postie tracking pixel (#7640)

* chore(deps): update codecov orb from 1.2.1 to v1.2.2

* chore(deps): update dep typescript from 4.2.4 to v4.3.2

* refactor: Renamed styled component and changed usage of NavLink component to JSX instead of calling like a function

* Use partnerArtist artwork connection for loading artist's artworks

* Added extra 10px of space above letters section on mobile

* Added key prop to NavLink components

* Updated tests

* chore: adds seo meta tags (#7639)

* Revert "chore: adds seo meta tags (#7639)"

This reverts commit 6107bdc.

* fix: prevent events duplications shows tab (#7647)

* Remove an event from upcoming/current events if it displays in the banner; Fix null check errors

* Add generated files

Co-authored-by: Ivan Badyulya <[email protected]>

* fix: SEO meta for Buyer Guarantee (#7648)

* chore: adds seo meta tags

* fix: trim whitespace from meta description

Co-authored-by: nastassia <[email protected]>
Co-authored-by: Cameron Rollheiser <[email protected]>
Co-authored-by: AL_Sutherland <[email protected]>
Co-authored-by: Jon Allured <[email protected]>
Co-authored-by: Christopher Pappas <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Kirill Zubarau <[email protected]>
Co-authored-by: Ashley Jelks <[email protected]>
Co-authored-by: Sarah Weir <[email protected]>
Co-authored-by: Ivan <[email protected]>
Co-authored-by: Ivan Badyulya <[email protected]>
Co-authored-by: Joey Aghion <[email protected]>
@artsy-peril artsy-peril bot mentioned this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant