feature: Webpack Chunking #7645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reduces the number of sub KiB bundles by using V2 application scope as the common denominator. * Restricts bundles to 240 KiB unzipped * Cleans up legacy imports accidentally included by the orders page.
joeyAghion
approved these changes
May 27, 2021
There was a problem hiding this comment.
The dependency clean-up seems like an obvious win. Some of the other novo/22820 simplification also seems helpful. Hard to tell about the deep-webpack stuff though.
What should we monitor to understand the production impact? Ideas:
- Total requests to assets CDN (after an initial warm-up period, given the name changes)
- I don't think we expect initial/landing page times to be better, right? But if navigations between modern pages should improve, maybe pages per session?
- ...others?
|
Nice! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies our Webpack bundling strategy to follow several common patterns used elsewhere in the industry.
Creates a minimal chunk for each App
Creates a minimal commons chunk for each App
Create a framework chunk for
@artsyframework code to ensure that it will not be cache-invalidatedCreate a framework chunk for core framework code to ensure that it will not be cache-invalidated
Creates library chunks for any large node_module dependencies
Creates shard chunks for any code used by multiple pages
Additional Optimizations
Notable Impacts:
Reduces the Artist page JS bundle payload by ~275 KiB compressed