fix: add redirection logic for works page #7614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweir27
reviewed
May 24, 2021
| return | ||
| } | ||
|
|
||
| const { partner } = props as any |
There was a problem hiding this comment.
Is it possible to get rid of this any?
Looks like you could also shorten this to if (!props.partner) ... which might avoid this as well.
There was a problem hiding this comment.
This way wouldn't avoid the problem. The TS defines props as field from found lib and can't find the partner field in render props type, that's why we decided avoiding the issue with as any
There was a problem hiding this comment.
@damassi do you know if there's a way to provide types for the render function?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA -> Add redirection logic for works tab. If no artworks or CMS field for works tab display is false it should redirect to the overview page