Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy #5657

Merged
merged 40 commits into from
May 28, 2020
Merged

Deploy #5657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
c9839b6
Made page number and cursor tracked by filter state. Removed paginate…
artsyjian May 26, 2020
b18e3ac
Made page number and cursor tracked by filter state. Removed paginate…
artsyjian May 26, 2020
9770e70
[Refactor] Remove references tto A/B test
damassi May 26, 2020
1701954
[Refactor] Delete unused routes
damassi May 26, 2020
b2bc73e
[Refactor] Delete unused apps / assetts
damassi May 27, 2020
fb25ef0
[Refactor] Delete Conversation and Purchases apps
damassi May 27, 2020
2d4512b
[Refactor] Rename experimental-app-shell -> artsy-v2
damassi May 27, 2020
1f20c7d
[Refactor] Dont bundle split all of order app
damassi May 27, 2020
f6f6b94
Fix react server warning
damassi May 27, 2020
87644e5
[Toolchain] Point jest cache at .jest/cache
damassi May 27, 2020
ceaf326
[Toolchain] Make jest graphql more robust
damassi May 27, 2020
be156e9
[Refactor] Fix failing tests
damassi May 27, 2020
be481b6
Add some wait to partner smoke test
damassi May 27, 2020
585c30f
[Refactor] Preload purchases app js bundle
damassi May 27, 2020
72dd5dd
make divider optional
lilyfromseattle May 27, 2020
8780f51
cleaned up comments
lilyfromseattle May 27, 2020
6bf557f
Merge pull request #5651 from artsy/promote-new-app-shell
damassi May 27, 2020
7cbfecc
[Refactor] Remove old eslint
damassi May 27, 2020
97fdf46
[Lib] Add latest eslint
damassi May 27, 2020
6c01630
[Lib] Add lint-staged
damassi May 27, 2020
063812b
[Lint] Fix all eslint errors
damassi May 27, 2020
760d5a5
[Artist] Fix scroll behavior on overview artist tab
damassi May 27, 2020
72f79f6
Merge pull request #5660 from artsy/add-eslint
damassi May 27, 2020
3dfbcdb
test
damassi May 28, 2020
9f0fa18
Merge pull request #5662 from artsy/fix-linting
damassi May 28, 2020
847034f
[Docs] Add docs about adding a new app
damassi May 28, 2020
2903b4a
Autofix eslint on save
damassi May 28, 2020
afb510e
[Lib] Bump typescript to latest
damassi May 28, 2020
9f5dbdc
Merge pull request #5663 from artsy/bump-typescript
damassi May 28, 2020
b479ee1
Update metaphysics schema
artsyit May 28, 2020
969ca4f
Update metaphysics schema (#5664)
artsy-peril[bot] May 28, 2020
31445ab
Merge pull request #5648 from artsyjian/auction-results-track-current…
zephraph May 28, 2020
4a904cf
Update metaphysics schema
artsyit May 28, 2020
30825d2
Update metaphysics schema (#5665)
artsy-peril[bot] May 28, 2020
572c6af
Drops old feature apps; renames feature-reaction app => feature
dzucconi May 21, 2020
b5ffc86
Merge pull request #5656 from lilyfromseattle/convo-select
zephraph May 28, 2020
517079b
Merge pull request #5661 from artsy/add-docs-around-new-app
damassi May 28, 2020
e8c8597
Merge pull request #5630 from dzucconi/fix/removes-old-feature-pages
damassi May 28, 2020
0771cfb
Fix conversation type conflict in ts 3.9.3
zephraph May 28, 2020
6d63174
Merge pull request #5668 from artsy/fix-conversation-type-issue
zephraph May 28, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
20 changes: 0 additions & 20 deletions .eslintrc

This file was deleted.

112 changes: 112 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
const path = require("path")

module.exports = {
parser: "@typescript-eslint/parser",

plugins: [
"react-hooks",
"@typescript-eslint",
// TODO: Add support for Graphql
/*, "graphql" */
],
extends: [
"eslint:recommended",
"plugin:react/recommended",
"plugin:react-hooks/recommended",
"plugin:@typescript-eslint/recommended",
"prettier",
],
parserOptions: {
ecmaFeatures: {
jsx: true,
},
ecmaVersion: 6,
// This significantly slows down linting and is needed for type-aware lint
// checks which we don't have atm.
// project: "./tsconfig.json",
sourceType: "module",
},
settings: {
react: {
version: "detect",
},
},
env: {
es6: true,
browser: true,
jest: true,
node: true,
},
rules: {
"@typescript-eslint/ban-ts-ignore": 0,
"@typescript-eslint/camelcase": 0,
"@typescript-eslint/explicit-function-return-type": 0,
"@typescript-eslint/explicit-member-accessibility": 0,
"@typescript-eslint/indent": 0,
"@typescript-eslint/member-delimiter-style": 0,
"@typescript-eslint/no-explicit-any": 0,
"@typescript-eslint/no-inferrable-types": 0,
"@typescript-eslint/no-use-before-define": 0,
"@typescript-eslint/no-unused-vars": 0,
"@typescript-eslint/no-var-requires": 0,
"react/display-name": 0,
"react/prop-types": 0,
"react-hooks/rules-of-hooks": "error",
"react-hooks/exhaustive-deps": "warn",
"sort-imports": [
"warn",
{
// Unfortunately there's no autofixer for this
ignoreDeclarationSort: true,
},
],

// FIXME: Investigate / reenable these rules. Disabled to introduce eslint
// into codebase.
"no-async-promise-executor": 0,
"no-case-declarations": 0,
"no-console": 0,
"no-constant-condition": 0,
"no-empty-pattern": 0,
"no-extra-boolean-cast": 0,
"no-inner-declarations": 0,
"no-irregular-whitespace": 0,
"no-prototype-builtins": 0,
"no-undef": 0,
"no-unreachable": 0,
"no-useless-escape": 0,
"prefer-const": 0,
"prefer-rest-params": 0,
"react/jsx-key": 0,
"react/jsx-no-target-blank": 0,
"react/no-direct-mutation-state": 0,
"react/no-find-dom-node": 0,
"react/no-unescaped-entities": 0,
"@typescript-eslint/no-empty-function": 0,
"@typescript-eslint/no-empty-interface": 0,
"@typescript-eslint/no-non-null-assertion": 0,

// "@typescript-eslint/no-unused-vars": [
// "error",
// {
// argsIgnorePattern: "^_",
// },
// ],
// "no-console": [
// "error",
// {
// allow: ["warn", "error"],
// },
// ],

// TODO: Add support for Graphql, but first need to fetch .json schema
// "graphql/template-strings": [
// "error",
// {
// env: "relay",
// schemaJsonFilepath: path.resolve(__dirname, "./data/schema.json"),
// tagName: "graphql",
// },
// ],
},
}
2 changes: 0 additions & 2 deletions .storybook/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const {
CI,
CMS_URL,
ENABLE_SIGN_IN_WITH_APPLE,
EXPERIMENTAL_APP_SHELL,
FACEBOOK_APP_NAMESPACE,
PREDICTION_URL,
FORCE_CLOUDFRONT_URL,
Expand Down Expand Up @@ -56,7 +55,6 @@ const sharifyPath = sharify({
CDN_URL,
CMS_URL,
ENABLE_SIGN_IN_WITH_APPLE,
EXPERIMENTAL_APP_SHELL,
FACEBOOK_APP_NAMESPACE,
FORCE_CLOUDFRONT_URL,
GEMINI_CLOUDFRONT_URL,
Expand Down
6 changes: 2 additions & 4 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
{
"editor.rulers": [
80
],
"editor.rulers": [80],
"editor.tabSize": 2,
"javascript.validate.enable": true,
"search.exclude": {
Expand Down Expand Up @@ -31,7 +29,7 @@
],
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.fixAll.tslint": true,
"source.fixAll.eslint": true,
"source.fixAll.stylelint": true
}
}
1 change: 1 addition & 0 deletions cypress/integration/partnerProfile.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ describe("/:partner_id", () => {
})
it("shows partner articles", () => {
cy.visit("gagosian-gallery/articles")
cy.wait(2000)
cy.contains("Articles")
})

Expand Down
38 changes: 38 additions & 0 deletions data/schema.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,7 @@ type Artist implements EntityWithFilterArtworksConnectionInterface & Node & Sear
priceRange: String
saleID: ID
size: Int
sizeBuckets: [ArtworkSizes]
sort: String
tagID: String
width: String
Expand Down Expand Up @@ -3168,6 +3169,22 @@ type ConditionReportRequest {
userID: ID
}

# Autogenerated input type of ConfirmPassword
input ConfirmPasswordInput {
# A unique identifier for the client performing the mutation.
clientMutationId: String

# User password to confirm.
password: String!
}

# Autogenerated return type of ConfirmPassword
type ConfirmPasswordPayload {
# A unique identifier for the client performing the mutation.
clientMutationId: String
valid: Boolean!
}

# Consignment Offer
type ConsignmentOffer {
commissionPercentWhole: Int
Expand Down Expand Up @@ -3508,6 +3525,7 @@ type CreateAppSecondFactorPayload {
input CreateBackupSecondFactorsInput {
# A unique identifier for the client performing the mutation.
clientMutationId: String
password: String
}

# Autogenerated return type of CreateBackupSecondFactors
Expand Down Expand Up @@ -3632,12 +3650,21 @@ type CreateSubmissionMutationPayload {

# Autogenerated input type of CreateViewingRoom
input CreateViewingRoomInput {
# Main text
body: String!

# A unique identifier for the client performing the mutation.
clientMutationId: String

# Introduction
introStatement: String!

# Partner Id
partnerId: String!

# Pullquote
pullQuote: String

# Title
title: String!
}
Expand Down Expand Up @@ -3869,6 +3896,7 @@ type dimensions {
input DisableSecondFactorInput {
# A unique identifier for the client performing the mutation.
clientMutationId: String
password: String
secondFactorID: ID!
}

Expand Down Expand Up @@ -3953,6 +3981,7 @@ input EnableSecondFactorInput {
# A unique identifier for the client performing the mutation.
clientMutationId: String
code: String!
password: String
secondFactorID: ID!
}

Expand Down Expand Up @@ -4016,6 +4045,7 @@ interface EntityWithFilterArtworksConnectionInterface {
priceRange: String
saleID: ID
size: Int
sizeBuckets: [ArtworkSizes]
sort: String
tagID: String
width: String
Expand Down Expand Up @@ -4153,6 +4183,7 @@ type Fair implements EntityWithFilterArtworksConnectionInterface & Node {
priceRange: String
saleID: ID
size: Int
sizeBuckets: [ArtworkSizes]
sort: String
tagID: String
width: String
Expand Down Expand Up @@ -4752,6 +4783,7 @@ type Gene implements Node & Searchable {
priceRange: String
saleID: ID
size: Int
sizeBuckets: [ArtworkSizes]
sort: String
tagID: String
width: String
Expand Down Expand Up @@ -5332,6 +5364,7 @@ type MarketingCollection {
priceRange: String
saleID: ID
size: Int
sizeBuckets: [ArtworkSizes]
sort: String
tagID: String
width: String
Expand Down Expand Up @@ -5794,6 +5827,7 @@ type Mutation {
commerceSubmitPendingOffer(
input: CommerceSubmitPendingOfferInput!
): CommerceSubmitPendingOfferPayload
confirmPassword(input: ConfirmPasswordInput!): ConfirmPasswordPayload

# Create an account request
createAccountRequest(
Expand Down Expand Up @@ -6545,6 +6579,7 @@ type Query {
priceRange: String
saleID: ID
size: Int
sizeBuckets: [ArtworkSizes]
sort: String
tagID: String
width: String
Expand Down Expand Up @@ -7700,6 +7735,7 @@ type Show implements EntityWithFilterArtworksConnectionInterface & Node {
priceRange: String
saleID: ID
size: Int
sizeBuckets: [ArtworkSizes]
sort: String
tagID: String
width: String
Expand Down Expand Up @@ -8077,6 +8113,7 @@ type Tag implements Node {
priceRange: String
saleID: ID
size: Int
sizeBuckets: [ArtworkSizes]
sort: String
tagID: String
width: String
Expand Down Expand Up @@ -8437,6 +8474,7 @@ type Viewer {
priceRange: String
saleID: ID
size: Int
sizeBuckets: [ArtworkSizes]
sort: String
tagID: String
width: String
Expand Down
Loading