Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected conversation missing "select" state #5656

Merged
merged 2 commits into from
May 28, 2020

Conversation

lilyfromseattle
Copy link
Contributor

@lilyfromseattle lilyfromseattle commented May 27, 2020

@ArtsyOpenSource
Copy link

Fails
🚫

Danger failed to run dangerfile.ts.

Error RangeError

Maximum call stack size exceeded
RangeError: Maximum call stack size exceeded
    at resolveStandardizedName (/home/circleci/project/node_modules/@babel/core/lib/config/files/plugins.js:97:33)
    at resolvePlugin (/home/circleci/project/node_modules/@babel/core/lib/config/files/plugins.js:54:10)
    at loadPlugin (/home/circleci/project/node_modules/@babel/core/lib/config/files/plugins.js:62:20)
    at createDescriptor (/home/circleci/project/node_modules/@babel/core/lib/config/config-descriptors.js:154:9)
    at /home/circleci/project/node_modules/@babel/core/lib/config/config-descriptors.js:109:50
    at Array.map (<anonymous>)
    at createDescriptors (/home/circleci/project/node_modules/@babel/core/lib/config/config-descriptors.js:109:29)
    at createPluginDescriptors (/home/circleci/project/node_modules/@babel/core/lib/config/config-descriptors.js:105:10)
    at /home/circleci/project/node_modules/@babel/core/lib/config/config-descriptors.js:63:49
    at cachedFunction (/home/circleci/project/node_modules/@babel/core/lib/config/caching.js:33:19)

Dangerfile

-----------------------------------^

Generated by 🚫 dangerJS against 8780f51

@zephraph
Copy link
Contributor

Looks great @lilyfromseattle. I think there's an opportunity to follow up and simplify some of the logic around when we add dividers to the snippet, but what you have here is good for now. 👍

@zephraph zephraph merged commit b5ffc86 into artsy:master May 28, 2020
@artsy-peril artsy-peril bot mentioned this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants