fix(consign): fixes inverted contrast; image placeholders #13452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzucconi
commented
Feb 2, 2024
| const collumnHeightMediumcreen = | ||
| ((width - 20 * 2 - 20 * 2 - 20 * 2) / 3) * aspectRatio | ||
| const collumnHeightBigScreen = | ||
| ((width - 40 * 2 - 40 * 2 - 40 * 2) / 3) * aspectRatio |
There was a problem hiding this comment.
Interesting in that, this was a lot of work to do something that is not so hard: https://www.notion.so/artsy/Handling-Images-On-The-Web-In-Force-5c6832bf4b3e431cb4830061ce057399
dzucconi
commented
Feb 2, 2024
| <Stack | ||
| gap={[0.5, 1]} | ||
| // Magic numbers to bottom align images | ||
| minHeight={[100, 200, 140]} |
There was a problem hiding this comment.
This should be structured so that we do this in 2 rows, eliminating the need for any manual adjustment. But this is fine for now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DIA-438
OK so this was dark mode related, but not in the way I thought.
These backgrounds were previously defined with:
background="black"—blackis of course a valid HTML color, not a themed value. I replaced it withblack100but, surprisingly,backgroundis not theme-aware. We typically use the propbg, which is.Additionally I fixed these images which were causing a content shift on page load. I do note that the assets we use are inadequately sized as well: we need much larger images to pull resizes from.