Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Enables incremental compiler option #trivial #2093

Closed
wants to merge 1 commit into from

Conversation

ashfurrow
Copy link
Contributor

@damassi brought this up on Slack and it seems like a great idea: https://artsy.slack.com/archives/C02BC3HEJ/p1581803473357200

@ds300
Copy link
Contributor

ds300 commented Feb 18, 2020

This unfortunately won't affect us because we use tsc with the noEmit option :(((

See here for details: microsoft/TypeScript#30661

The only workaround people have found so far is to turn off noEmit and dump the compiler output somewhere out-of-the-way.

For me, tsc runs in 10s and pretty much only ever as part of the prepush hook, so I don't mind putting up with this until the TS team finds a solution. Maybe we can nudge our friend on the inside? 🙊

If this is a big deal for other devs then I'm onboard to try out the workaround. What do you think?

@ashfurrow
Copy link
Contributor Author

Gotcha, thanks for that context @ds300 👍 Orta is focused on the TypeScript website at the moment, and based on how the TS team is structured, I don't think we'd be able to nudge the team very far right now.

This wasn't a big deal for me, it only seemed like a quick win. I'm fine closing – thanks for the context! 🙏

@ashfurrow ashfurrow closed this Feb 18, 2020
@ashfurrow ashfurrow deleted the incremental-compiles branch February 18, 2020 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants