Sentry breaking the build

[orta]

Seeing getsentry/sentry-react-native#32

Since we got Sentry + RN set up, builds are failing

▸ Compiling RNSentry.m
⚠️  /Users/travis/build/artsy/emission-nebula/emission/node_modules/react-native-sentry/ios/RNSentry.m:27:5: expression result unused [-Wunused-value]
[[bridge moduleForName:@"ExceptionsManager"] initWithDelegate:sentry];
        ~~~ ^
⚠️  /Users/travis/build/artsy/emission-nebula/emission/node_modules/react-native-sentry/ios/RNSentry.m:108:86: undeclared selector 'callNativeModule:method:params:' [-Wundeclared-selector]
uintptr_t callNativeModuleAddress = [RCTBatchedBridge instanceMethodForSelector:@selector(callNativeModule:method:params:)];
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
⚠️  /Users/travis/build/artsy/emission-nebula/emission/node_modules/react-native-sentry/ios/RNSentry.m:108:15: incompatible pointer to integer conversion initializing 'uintptr_t' (aka 'unsigned long') with an expression of type 'IMP' (aka 'void (*)(void)') [-Wint-conversion]
uintptr_t callNativeModuleAddress = [RCTBatchedBridge instanceMethodForSelector:@selector(callNativeModule:method:params:)];
                                                                                     ^
⚠️  /Users/travis/build/artsy/emission-nebula/emission/node_modules/react-native-sentry/ios/RNSentry.m:111:30: undeclared selector 'callNativeModule:method:params:' [-Wundeclared-selector]
@selector(callNativeModule:method:params:),
              ^                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
❌  /Users/travis/build/artsy/emission-nebula/emission/node_modules/react-native-sentry/ios/RNSentry.m:249:28: no visible @interface for 'SentryClient' declares the selector 'reportReactNativeCrashWithError:stacktrace:terminateProgram:'
[[SentryClient shared] reportReactNativeCrashWithError:error stacktrace:stack terminateProgram:terminateProgram];
                             ^
▸ Compiling RNSentryEventEmitter.m
▸ Compiling SentryReactNative-dummy.m
▸ Compiling SentryReactNative_vers.c
▸ Compiling RNSentry.m
** ARCHIVE FAILED **
The following build commands failed:
CompileC /Users/travis/Library/Developer/Xcode/DerivedData/Emission-fillzptesxgqaydtzjjvxbvqdesz/Build/Intermediates/ArchiveIntermediates/Emission/IntermediateBuildFilesPath/Pods.build/Deploy-iphoneos/SentryReactNative.build/Objects-normal/armv7/RNSentry.o /Users/travis/build/artsy/emission-nebula/emission/node_modules/react-native-sentry/ios/RNSentry.m normal armv7 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
[09:08:43]: Exit status: 65
[09:08:43]: 📋  For a more detailed error log, check the full log at:
[09:08:43]: 📋  /Users/travis/Library/Logs/gym/Emission-Emission.log

[orta]

I added a pod repo update but that didn't help - 2058e78

[orta]

It installed Installing Sentry (2.1.9) which isn't latest, will try updating the lockfile

[orta]

It's because our build toolchain now contains Swift, we have to use a specific build of Xcode now.

Making sure travis is running on Xcode 8.3 conceptually fixed this, but the build failed due to the pod resource script which feels really weird = https://travis-ci.org/artsy/emission-nebula/builds/236080641

[orta]

These issues look like they're covered in https://docs.travis-ci.com/user/common-build-problems/#Mac%3A-macOS-Sierra-(10.12)-Code-Signing-Errors

[orta]

Sigh, getting there. Slowly

[orta]

Shame, I'll have to do all this then 3.0 will come out and it'll all be for nothing - getsentry/sentry-cocoa#154

[orta]

Also tried: artsy/emission#572

[orta]

Ran the setup locally, found this:

[orta]

Came to the conclusion on an airplane that I can override the Pod at our app level to just provide a fake API which we use, and we can use that to avoid all these swift issues

[orta]

Now using libraries again, shipped a few releases manually. I can archive correctly in Xcode, but struggling to do it right inside Fastlane

[orta]

So, the later issues around empty archives are fixed with 705a32d