Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Play and summarize Artsy podcasts. #56

Merged
merged 1 commit into from
Feb 8, 2017
Merged

Conversation

dblock
Copy link
Contributor

@dblock dblock commented Feb 7, 2017

Closes #51.

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.6%) to 75.92% when pulling 0e32e06 on dblock:podcasts into 372f9cd on artsy:master.

@coveralls
Copy link

coveralls commented Feb 7, 2017

Coverage Status

Coverage increased (+1.5%) to 85.953% when pulling 0e32e06 on dblock:podcasts into 372f9cd on artsy:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 85.953% when pulling 9e15972 on dblock:podcasts into 372f9cd on artsy:master.

Copy link
Contributor

@ashkan18 ashkan18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cooooool!

token: streamUrl,
offsetInMilliseconds: 0
}
res.audioPlayerPlayStream('REPLACE_ALL', stream);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic?! Need to read about audoPlayerPlayStream

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a "native" function of the API of alexa-app, see https://github.com/alexa-js/alexa-app

_.mixin(require('underscore.string').exports());

function Podcast() {
this.rssUrl = 'https://feeds.soundcloud.com/users/soundcloud:users:211089382/sounds.rss';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest make this an env but I guess there is no point if we lose env everytime we deploy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and it's not likely to change without having to do code changes.

@dblock dblock merged commit abc9ee6 into artsy:master Feb 8, 2017
@dblock dblock deleted the podcasts branch February 23, 2017 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants