Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(cx-2547): sorting MyCollection Artworks for artworks without price paid. #6680

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Fix(cx-2547): sorting MyCollection Artworks for artworks without price paid. #6680

merged 2 commits into from
Apr 29, 2022

Conversation

lordkiz
Copy link
Contributor

@lordkiz lordkiz commented Apr 28, 2022 •
edited by jira bot
Loading

This PR resolves CX-2547

Description

  • Fixes issue where artworks without pricePaid are not considered in the sorting, so they appear above when sorted from High to Low and below when sorted from Low to High
sort-fix.mp4

PR Checklist

  • I tested my changes on iOS / Android.
  • I added screenshots or videos to illustrate my changes.
  • I added Tests and Stories for my changes.
  • I added an app state migration.
  • I hid my changes behind a feature flag.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • sorting MyCollection Artworks for artworks without price paid. - kizito

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look on our docs, or get in touch with us.

@lordkiz lordkiz requested a review from olerichter00 April 28, 2022 14:44
olerichter00
olerichter00 approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@olerichter00 olerichter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@olerichter00
Copy link
Contributor

#squashongreen

@olerichter00 olerichter00 added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Apr 29, 2022
@artsy-peril artsy-peril bot merged commit 50e9845 into main Apr 29, 2022
@artsy-peril artsy-peril bot deleted the lordkiz/cx-2547-Fix-sorting-MyCollection-Artworks branch April 29, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olerichter00 olerichter00 olerichter00 approved these changes

Assignees

@olerichter00 olerichter00

Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lordkiz @olerichter00