Sailthru exclusion #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloy
force-pushed
the
sailthru-exclusion
branch
from
c751dbe
to
40fe296
Compare
kanaabe
reviewed
Apr 30, 2017
| * encoded URL contains a base64 version of the actual Artsy URL, so we can exlcude based on that. This script takes the | ||
| * patterns specified in the apple-app-site-association.json file and generates the encoded versions of them. Or, if a | ||
| * pattern was removed, it removes the corresponding encoded pattern. | ||
| */ |
kanaabe
reviewed
Apr 30, 2017
| "NOT /article/*", | ||
| "NOT /2016-year-in-art", | ||
| "NOT *L2FydGljbGUv*", | ||
| "NOT *LzIwMTYteWVhci1pbi1hcnQ=*", |
There was a problem hiding this comment.
It’s the base64 encoded version of /2016-year-in-art.
|
👍 Cool, thanks for catching this! |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/artsy/collector-experience/issues/240
From Sailthru support:
I have verified that this indeed correctly excludes editorial content.